Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: location messages backup (WPB-5826) #2324

Merged
merged 3 commits into from
Dec 21, 2023
Merged

feat: location messages backup (WPB-5826) #2324

merged 3 commits into from
Dec 21, 2023

Conversation

yamilmedina
Copy link
Contributor

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Location messages are not included in backups currently.

Causes (Optional)

Not implemented.

Solutions

Implement export and import necessary queries.

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Dec 21, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 21, 2023 •
edited
Loading

Test Results

2 787 tests  ±0   2 683 ✔️ ±0   2m 46s ⏱️ +7s
   488 suites ±0      104 💤 ±0 
   488 files   ±0          0 ❌ ±0 

Results for commit 18ece2e. ± Comparison against base commit 8c0b71d.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Dec 21, 2023 •
edited
Loading

Datadog Report

All test runs d2a9a84 🔗

✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2343 67 5m 1.09s Link
kalium-jvm 0 0 0 2683 104 8m 53.04s Link

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8c0b71d) 58.74% compared to head (18ece2e) 58.74%.

Additional details and impacted files 
@@              Coverage Diff              @@
##             develop    #2324      +/-   ##
=============================================
- Coverage      58.74%   58.74%   -0.01%     
  Complexity        21       21              
=============================================
  Files           1107     1107              
  Lines          42712    42729      +17     
  Branches        4001     4001              
=============================================
+ Hits           25092    25100       +8     
- Misses         15849    15858       +9     
  Partials        1771     1771
Files Coverage Δ
...wire/kalium/persistence/backup/DatabaseImporter.kt 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c0b71d...18ece2e. Read the comment docs.

@yamilmedina yamilmedina requested review from a team, typfel, alexandreferris, mchenani, ohassine, saleniuk and MohamadJaara and removed request for a team December 21, 2023 11:36
@yamilmedina yamilmedina added this pull request to the merge queue Dec 21, 2023
Merged via the queue into develop with commit e07f991 Dec 21, 2023
15 checks passed
@yamilmedina yamilmedina deleted the feat/location-backups branch December 21, 2023 13:36
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandreferris alexandreferris alexandreferris approved these changes

@ohassine ohassine ohassine approved these changes

@typfel typfel Awaiting requested review from typfel typfel was automatically assigned from wireapp/android

@mchenani mchenani Awaiting requested review from mchenani mchenani was automatically assigned from wireapp/android

@saleniuk saleniuk Awaiting requested review from saleniuk saleniuk was automatically assigned from wireapp/android

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara

Assignees

@yamilmedina yamilmedina

Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 👕 size: S type: feature ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yamilmedina @codecov-commenter @alexandreferris @ohassine